Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable kapa.ai #1447

Merged
merged 1 commit into from
Jul 10, 2023
Merged

fix: disable kapa.ai #1447

merged 1 commit into from
Jul 10, 2023

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jul 10, 2023

Kapa.ai is a nice tool but the bundle size is way too big, dragging down page speed significantly. Until the Kapa.ai widget is optimized, or we find a way to lazy load the script, we need to disable it.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@aeneasr
fix: disable kapa.ai
242e5f1 
Kapa.ai is a nice tool but the bundle size is way too big, dragging down page speed significantly. Until the Kapa.ai widget is optimized, or we find a way to lazy load the script, we need to disable it.
@aeneasr
Copy link
Member Author

aeneasr commented Jul 10, 2023

@vinckr fyi

kmherrmann
kmherrmann approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@kmherrmann kmherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let'd do this temporarily and look at the impact on page speed and seo

@kmherrmann kmherrmann merged commit 73f9ab6 into master Jul 10, 2023
@kmherrmann kmherrmann deleted the remove-kapa branch July 10, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmherrmann kmherrmann kmherrmann approved these changes

@vinckr vinckr Awaiting requested review from vinckr vinckr is a code owner

@zepatrik zepatrik Awaiting requested review from zepatrik zepatrik is a code owner

@piotrmsc piotrmsc Awaiting requested review from piotrmsc piotrmsc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeneasr @kmherrmann